Fix bug in get_clean_sql and add pre-requisite and additional notes on server naming #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjrace
changed the title
cjrace
force-pushed
the
update-sql-connection-vignette
branch
from
4bd150d to
798f9c2
Compare
chfoster
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of changes
Fixing a bug in the
get_clean_sql()function that mean the additional settings wouldn't return the SQL statement. Plus a quick update to the notes in the connecting to SQL vignetteWhy are these changes being made?
I was following it on a new laptop and noticed the bug as well as a couple of assumed things I thought it was worth writing down.
Detailed description of changes
get_clean_sql()to make sure that the function always returns the SQL statement even when additional settings are usedAdditional information for reviewers
Issue ticket number/s and link
None